Use namespaced math functions #39553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
force-pushed
the
namespaced-math
branch
from
2bd671f to
71c62dc
Compare
kevingranade
commented
Apr 14, 2020
kevingranade
commented
Apr 14, 2020
ZhilkinSerg
added
[C++]
ZhilkinSerg
reviewed
Apr 14, 2020
kevingranade
commented
Apr 14, 2020
kevingranade
commented
Apr 14, 2020
kevingranade
commented
Apr 14, 2020
kevingranade
commented
Apr 14, 2020
|
This pull request fixes 91 alerts when merging aaf0ff7 into a015c70 - view on LGTM.com fixed alerts:
|
|
Only 91? Well crap there's definitely something wrong. It looks like lgtm isn't counting abs() or sqrt(), and maybe some others. |
|
My guess is that these might actually be macros, which is annoying because AFAICT that means lgtm can't do checks based on their presence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Use the C++ style math functions in the std namespace.
Testing
It should be fine as long as it builds and lgtm says it closes a bunch of warnings.